Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take a screenshot on each failed expect #154

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Moke96
Copy link

@Moke96 Moke96 commented Jun 13, 2019

Addresses #102, im not sure if it breaks the pathbuilder.

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #154 into master will increase coverage by 0.05%.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   43.96%   44.02%   +0.05%     
==========================================
  Files           3        3              
  Lines        8579     8169     -410     
  Branches     1922     1746     -176     
==========================================
- Hits         3772     3596     -176     
+ Misses       4807     4573     -234
Impacted Files Coverage Δ
index.js 42.54% <59.09%> (-0.11%) ⬇️
app/util.js 99.03% <0%> (+6.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1360f5b...262ba89. Read the comment docs.

@miller45
Copy link
Collaborator

Quite interesting ...will have a look soon...and make the feature optinal...

@miller45
Copy link
Collaborator

@Moke96 sorry. I did not forget, but I were busy with family... hope I find time this weekend...

@Moke96
Copy link
Author

Moke96 commented Jun 28, 2019

@miller45 don't worry. Take your time with family stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants